[MOO-2070]: Conditional terser configuration for react-native-reanimated compatibility MX10 #366
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR implements dynamic terser configuration for React Native builds based on the detection of react-native-reanimated as a dependency. When reanimated is present, terser applies comprehensive minification settings that preserve worklet function names and classes required for reanimated's functionality. Without reanimated, minimal terser configuration is applied.
Key Changes:
- Added runtime detection of
react-native-reanimatedin package.json dependencies/peerDependencies - Implemented conditional terser configuration with full preservation settings for reanimated projects
- Maintained backward compatibility with minimal terser settings for non-reanimated projects
Comments suppressed due to low confidence (1)
patches/@mendix+pluggable-widgets-tools+10.15.0+002+conditional-terser-for-reanimated.patch:1
- The
hasReanimatedconstant is recalculated on every call togetCommonPlugins. Since package.json dependencies don't change during the build process, this check should be moved outside the function to avoid redundant file system reads and JSON parsing.
diff --git a/node_modules/@mendix/pluggable-widgets-tools/configs/rollup.config.native.js b/node_modules/@mendix/pluggable-widgets-tools/configs/rollup.config.native.js
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
patches/@mendix+pluggable-widgets-tools+10.15.0+002+conditional-terser-for-reanimated.patch
Show resolved
Hide resolved
karahanharunn
approved these changes
Oct 23, 2025
NikolaSimsic
approved these changes
Oct 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds conditional terser minification based on the presence of
react-native-reanimateddependency.Changes
react-native-reanimatedin package.json dependencies/peerDependenciesmangleandcompressdisabledmangledisabledMotivation
React Native Reanimated requires specific minification settings to preserve worklet functions and their context. This change ensures proper terser configuration is applied automatically based on project dependencies.
Testing